[webkit-reviews] review granted: [Bug 178987] [Conic Gradients] Add support for parsing conic gradients : [Attachment 325286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 29 14:38:09 PDT 2017


Dean Jackson <dino at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 178987: [Conic Gradients] Add support for parsing conic gradients
https://bugs.webkit.org/show_bug.cgi?id=178987

Attachment 325286: Patch

https://bugs.webkit.org/attachment.cgi?id=325286&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 325286
  --> https://bugs.webkit.org/attachment.cgi?id=325286
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325286&action=review

> LayoutTests/ChangeLog:9
> +	   [Conic Gradients] Add support for parsing conic gradients
> +	   https://bugs.webkit.org/show_bug.cgi?id=178987
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * fast/gradients/conic-gradient-parsing-expected.txt: Added.
> +	   * fast/gradients/conic-gradient-parsing.html: Added.

Would be nice if these could be WPT proposals in http/wpt/

> LayoutTests/fast/gradients/conic-gradient-parsing.html:50
> +    for(var x = 0; x < 500; x++)

Nit: space after for

> LayoutTests/fast/gradients/conic-gradient-parsing.html:51
> +	   s += "white " + (x/500) + "%, " + ((2 * x + 1) / 1000) + "%, ";

Nit: s += `white ${x/500}%, ${(2 * x + 1) / 1000}%, `;


More information about the webkit-reviews mailing list