[webkit-reviews] review granted: [Bug 178992] Implement "bitmaprenderer" CanvasRenderingContext : [Attachment 325292] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 29 14:33:16 PDT 2017


Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 178992: Implement "bitmaprenderer" CanvasRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=178992

Attachment 325292: Patch

https://bugs.webkit.org/attachment.cgi?id=325292&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 325292
  --> https://bugs.webkit.org/attachment.cgi?id=325292
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325292&action=review

> Source/WebCore/html/ImageBitmap.cpp:563
> +    m_detached = true;

Not related to this change, but is the m_detached useful? I would think it
always corresponds to whether m_bitmapData is null or not.


More information about the webkit-reviews mailing list