[webkit-reviews] review denied: [Bug 178160] [GStreamer][MSE] Trim space between codecs : [Attachment 324667] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 26 04:43:18 PDT 2017
Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 178160: [GStreamer][MSE] Trim space between codecs
https://bugs.webkit.org/show_bug.cgi?id=178160
Attachment 324667: Patch
https://bugs.webkit.org/attachment.cgi?id=324667&action=review
--- Comment #20 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 324667
--> https://bugs.webkit.org/attachment.cgi?id=324667
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324667&action=review
Even when I did an r+ to the original patch, I think Charlie is right and you
didn't address his comments in this patch. Maybe I misunderstood him but I just
gave some guidance of how I think it shold be done.
> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:602
> + if (!MediaPlayerPrivateGStreamerMSE::supportsCodecs({
originalMediaType })) {
If you keep the original signature + the overload, you don't need this.
> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:635
> + if (!MediaPlayerPrivateGStreamerMSE::supportsCodecs({ structureName
})) {
Ditto.
>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:844
> + for (String codec : codecs) {
> + // Codecs might have whitespace around, e.g. when the string "vp8,
vorbis" is split.
> + codec = codec.stripWhiteSpace();
I think this won't be needed if you take const ContentType& here because that
logic seems to be in that class.
>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h
:86
> - static bool supportsCodecs(const String& codecs);
> + static bool supportsCodecs(const Vector<String>& codecs);
I think this function signature should left unchanged and create an overloaded
that takes a const ContentType&. The original function should create the
ContentType from a String and pass it to the overloaded function.
More information about the webkit-reviews
mailing list