[webkit-reviews] review granted: [Bug 178625] REGRESSION(r222090): [HarfBuzz] Arabic shaping is broken except for first word in line : [Attachment 324979] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 26 04:54:53 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 178625: REGRESSION(r222090): [HarfBuzz] Arabic shaping is broken except for
first word in line
https://bugs.webkit.org/show_bug.cgi?id=178625

Attachment 324979: Patch

https://bugs.webkit.org/attachment.cgi?id=324979&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 324979
  --> https://bugs.webkit.org/attachment.cgi?id=324979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324979&action=review

>
Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:153
> +	   // FIXME: cover all other cases mentioned in the spec (ie. brackets
or quotation marks).
> +	   // https://bugs.webkit.org/show_bug.cgi?id=177003.

This is probably important.


More information about the webkit-reviews mailing list