[webkit-reviews] review denied: [Bug 178393] The authentication challenge sender should not be used when network session is used. : [Attachment 324411] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 20 11:04:10 PDT 2017


Alex Christensen <achristensen at apple.com> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 178393: The authentication challenge sender should not be used when network
session is used.
https://bugs.webkit.org/show_bug.cgi?id=178393

Attachment 324411: Patch

https://bugs.webkit.org/attachment.cgi?id=324411&action=review




--- Comment #17 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 324411
  --> https://bugs.webkit.org/attachment.cgi?id=324411
Patch

And in the case that we're receiving an authentication challenge from the
frame, we shouldn't just do nothing with it or that would break AppCache
authentication.  We need to land https://bugs.webkit.org/show_bug.cgi?id=178540
and remove that entire code path.


More information about the webkit-reviews mailing list