[webkit-reviews] review granted: [Bug 178567] When destroying a resource, register "only" the clients who are losing their resource as having pending resources : [Attachment 324358] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 20 11:01:40 PDT 2017
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 178567: When destroying a resource, register "only" the clients who are
losing their resource as having pending resources
https://bugs.webkit.org/show_bug.cgi?id=178567
Attachment 324358: Patch
https://bugs.webkit.org/attachment.cgi?id=324358&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324358
--> https://bugs.webkit.org/attachment.cgi?id=324358
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324358&action=review
> Source/WebCore/rendering/svg/SVGResources.cpp:391
> m_clipperFilterMaskerData->masker = 0;
These 0 should all be nullptr, right?
> Source/WebCore/rendering/svg/SVGResources.h:70
> + bool resourceDestroyed(RenderSVGResourceContainer&);
Please add a comment saying what the return value means, or use an enum.
More information about the webkit-reviews
mailing list