[webkit-reviews] review granted: [Bug 177836] RenderMenuList should not hold raw pointers : [Attachment 322581] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 3 14:27:18 PDT 2017
Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 177836: RenderMenuList should not hold raw pointers
https://bugs.webkit.org/show_bug.cgi?id=177836
Attachment 322581: Patch
https://bugs.webkit.org/attachment.cgi?id=322581&action=review
--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 322581
--> https://bugs.webkit.org/attachment.cgi?id=322581
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=322581&action=review
> Source/WebCore/rendering/RenderMenuList.cpp:109
> + m_innerBlock = makeWeakPtr(*newInnerBlock.get());
No need for .get()
More information about the webkit-reviews
mailing list