[webkit-reviews] review granted: [Bug 177770] SharedStringHashStore should support removing hashes : [Attachment 322553] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 3 14:24:01 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 177770: SharedStringHashStore should support removing hashes
https://bugs.webkit.org/show_bug.cgi?id=177770

Attachment 322553: Patch

https://bugs.webkit.org/attachment.cgi?id=322553&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 322553
  --> https://bugs.webkit.org/attachment.cgi?id=322553
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322553&action=review

> Source/WebKit/Shared/SharedStringHashTable.cpp:107
> +bool SharedStringHashTable::remove(WebCore::SharedStringHash
sharedStringHash)

It would be nice if we could have subroutines for things like finding the slot.
Also, we should add a FIXME comment indicating that sometimes we will want to
rehash to save memory if the capacity becomes too low.


More information about the webkit-reviews mailing list