[webkit-reviews] review granted: [Bug 180190] [DFG][FTL] operationHasIndexedProperty does not consider negative int32_t : [Attachment 327972] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 30 12:31:26 PST 2017


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 180190: [DFG][FTL] operationHasIndexedProperty does not consider negative
int32_t
https://bugs.webkit.org/show_bug.cgi?id=180190

Attachment 327972: Patch

https://bugs.webkit.org/attachment.cgi?id=327972&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 327972
  --> https://bugs.webkit.org/attachment.cgi?id=327972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327972&action=review

r=me.  Is it possible to defer landing this until after
https://bugs.webkit.org/show_bug.cgi?id=180192 is fixed?

> Source/JavaScriptCore/dfg/DFGOperations.cpp:1817
> +	   // Go the slowest way possible becase negative indices don't use
indexed storage.

typo: /becase/because/


More information about the webkit-reviews mailing list