[webkit-reviews] review granted: [Bug 180168] Populate self.registration.installing/waiting/active inside service workers : [Attachment 327987] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 180168: Populate self.registration.installing/waiting/active inside service
workers
https://bugs.webkit.org/show_bug.cgi?id=180168

Attachment 327987: Patch

https://bugs.webkit.org/attachment.cgi?id=327987&action=review




--- Comment #7 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 327987
  --> https://bugs.webkit.org/attachment.cgi?id=327987
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327987&action=review

> Source/WTF/wtf/CrossThreadCopier.h:144
> +template<typename T> struct CrossThreadCopierBase<false, false,
std::optional<T>> {

Nice

> Source/WebCore/workers/service/ServiceWorker.cpp:-72
> -    // FIXME: Once we support service workers from workers, this might need
to change.
> -    RELEASE_ASSERT(isMainThread());

I was right!!!