[webkit-reviews] review granted: [Bug 180005] [GTK][WPE] Add "enable-encryptedmedia" property to WebKitWebSettings : [Attachment 327639] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 27 10:20:38 PST 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 180005: [GTK][WPE] Add "enable-encryptedmedia" property to
WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=180005

Attachment 327639: Patch

https://bugs.webkit.org/attachment.cgi?id=327639&action=review




--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 327639
  --> https://bugs.webkit.org/attachment.cgi?id=327639
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327639&action=review

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:1299
> +	* This property is available only if the EncryptedMedia feature is
enabled at build time

One last change: "is available only" -> "will only work as intended". Since the
property will actually always be available, it just won't do anything.


More information about the webkit-reviews mailing list