[webkit-reviews] review granted: [Bug 180022] [FTL] Support DeleteById and DeleteByVal : [Attachment 327596] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 180022: [FTL] Support DeleteById and DeleteByVal
https://bugs.webkit.org/show_bug.cgi?id=180022

Attachment 327596: Patch

https://bugs.webkit.org/attachment.cgi?id=327596&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 327596
  --> https://bugs.webkit.org/attachment.cgi?id=327596
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327596&action=review

> Source/JavaScriptCore/ChangeLog:11
> +	   We should increase the coverage of FTL. Even if the code includes
DeleteById,
> +	   it does not mean that remaining part of the code should not be
optimized in FTL.
> +	   Right now, even CallEval and `with` scope are handled in FTL.
> +

Nice. I remember doing this a while ago too locally! I forgot to land it :(