[webkit-reviews] review granted: [Bug 179912] [DFG] Add NormalizeMapKey DFG IR : [Attachment 327417] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 179912: [DFG] Add NormalizeMapKey DFG IR
https://bugs.webkit.org/show_bug.cgi?id=179912

Attachment 327417: Patch

https://bugs.webkit.org/attachment.cgi?id=327417&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 327417
  --> https://bugs.webkit.org/attachment.cgi?id=327417
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327417&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1115
> +	   forNode(node).makeHeapTop();

Is it worth doing constant folding here based on child1's type?

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:5195
> +	       // Give key and bucket's key are already normalized. So if
64-bit compare fails and one is not a cell, they're definitely not equal.

"Give key and bucket's key" => "The input key and bucket's key"

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:8585
> +	   m_out.appendTo(passThroughCase, continuation);
> +	   ValueFromBlock fastResult = m_out.anchor(key);
> +	   m_out.jump(continuation);

This doesn't need to be a block. You can make the upsilon at the top, and make
everything that jumps to "passThroughCase" jump to continuation.