[webkit-reviews] review granted: [Bug 179892] Detect __declspec within JSBase.h : [Attachment 327375] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 179892: Detect __declspec within JSBase.h
https://bugs.webkit.org/show_bug.cgi?id=179892

Attachment 327375: Patch

https://bugs.webkit.org/attachment.cgi?id=327375&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 327375
  --> https://bugs.webkit.org/attachment.cgi?id=327375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327375&action=review

> Source/JavaScriptCore/API/JSBase.h:80
> +#ifndef __has_declspec_attribute
> +#if defined(WIN32) || defined(_WIN32) || defined(__CC_ARM) ||
defined(__ARMCC__)
> +#define __has_declspec_attribute(x) 1
> +#else
> +#define __has_declspec_attribute(x) 0
> +#endif
> +#endif

Defining this macro isn’t great in a public header like JSBase.h, but I guess
we can live with it.

> Source/JavaScriptCore/API/JSBase.h:88
> +#elif (__has_declspec_attribute(dllimport) &&
__has_declspec_attribute(dllexport))

No need for these parentheses.