[webkit-reviews] review granted: [Bug 179893] Add declspec within WebKit API : [Attachment 327377] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 179893: Add declspec within WebKit API
https://bugs.webkit.org/show_bug.cgi?id=179893

Attachment 327377: Patch

https://bugs.webkit.org/attachment.cgi?id=327377&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 327377
  --> https://bugs.webkit.org/attachment.cgi?id=327377
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327377&action=review

Seems OK to land it like this, although it doesn’t seem exactly right.

> Source/WebKit/Shared/API/c/WKDeclarationSpecifiers.h:36
> +#ifndef __has_declspec_attribute
> +#if defined(WIN32) || defined(_WIN32) || defined(__CC_ARM) ||
defined(__ARMCC__)
> +#define __has_declspec_attribute(x) 1
> +#else
> +#define __has_declspec_attribute(x) 0
> +#endif
> +#endif

This doesn’t seem quite right to me; it’s not great that
__has_declspec_attribute(THIS_DECLSPEC_ATTRIBUTE_IS_BOGUS_AND_DOES_NOT_EXIST)
will return true on many platforms.