[webkit-reviews] review requested: [Bug 179365] REGRESSION(r223773): [GTK] WebKitWebInspector bring-to-front signal is emitted right after open-window : [Attachment 326198] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 7 00:23:56 PST 2017
Carlos Garcia Campos <cgarcia at igalia.com> has asked for review:
Bug 179365: REGRESSION(r223773): [GTK] WebKitWebInspector bring-to-front signal
is emitted right after open-window
https://bugs.webkit.org/show_bug.cgi?id=179365
Attachment 326198: Patch
https://bugs.webkit.org/attachment.cgi?id=326198&action=review
--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 326198
--> https://bugs.webkit.org/attachment.cgi?id=326198&action=review
Patch
I'm not happy adding a platform ifdef to WebInspectorProxy.cpp after a
refactoring to share code, but in this case I don't see a better way. Going
back to platformOpen() when only one line differs is not better.
More information about the webkit-reviews
mailing list