[webkit-reviews] review granted: [Bug 179162] Add platform argument for syncing script. : [Attachment 325698] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 6 22:33:35 PST 2017


Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 179162: Add platform argument for syncing script.
https://bugs.webkit.org/show_bug.cgi?id=179162

Attachment 325698: Patch

https://bugs.webkit.org/attachment.cgi?id=325698&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 325698
  --> https://bugs.webkit.org/attachment.cgi?id=325698
Patch

In the long term, we should replace these "global" arguments and always use the
format where the key of a dictionary is the buildbot property as used in
repository groups. For now, this is fine.


More information about the webkit-reviews mailing list