[webkit-reviews] review granted: [Bug 172684] [WebIDL] @@iterator should only be accessed once when disambiguating a union type : [Attachment 311429] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 172684: [WebIDL] @@iterator should only be accessed once when
disambiguating a union type
https://bugs.webkit.org/show_bug.cgi?id=172684

Attachment 311429: Patch

https://bugs.webkit.org/attachment.cgi?id=311429&action=review




--- Comment #7 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 311429
  --> https://bugs.webkit.org/attachment.cgi?id=311429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311429&action=review

r=me

> Source/WebCore/ChangeLog:12
> +	   the sequence conversion code re-accessed it, which is observable and
wrong.

Yeah. It reminds me of the implementation of Array.from.