[webkit-reviews] review granted: [Bug 172686] [JSC][Linux][FreeBSD] Use faster Interpreter::getOpcodeID() : [Attachment 311435] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 172686: [JSC][Linux][FreeBSD] Use faster Interpreter::getOpcodeID()
https://bugs.webkit.org/show_bug.cgi?id=172686

Attachment 311435: Patch

https://bugs.webkit.org/attachment.cgi?id=311435&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 311435
  --> https://bugs.webkit.org/attachment.cgi?id=311435
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311435&action=review

r=me

> Source/WTF/wtf/Platform.h:920
> +    (CPU(X86) || CPU(X86_64) || CPU(ARM64) || CPU(ARM_THUMB2)) &&
(OS(DARWIN) || OS(LINUX) || OS(FREEBSD))

Should this be enabled for all Unix OSes?  If so, we can just drop the
OS(DARWIN) instead.  We already filter out MSVC above.	What do you think?