[webkit-reviews] review granted: [Bug 172540] [Win] Create unique network storage session for each DRT. : [Attachment 311119] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 172540: [Win] Create unique network storage session for each DRT.
https://bugs.webkit.org/show_bug.cgi?id=172540

Attachment 311119: Patch

https://bugs.webkit.org/attachment.cgi?id=311119&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 311119
  --> https://bugs.webkit.org/attachment.cgi?id=311119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311119&action=review

Wow -- I wonder how many problems this has caused in Windows testing over the
years!?!  Thanks for fixing this. r=me.

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:95
> +    session =
adoptCF(wkCreatePrivateStorageSession(sessionName.createCFString().get(),
defaultStorageSession().platformSession()));

It's weird that we have NetworkStorageSession::defaultStorageSession() and
NetworkStorageSession::defaultNetworkStorageSession(). How does anyone know
which one to use?

It looks like 'defaultNetworkStorageSession' just returns the (potentially
uninitialized) storage session, while 'defaultStorageSession' builds a new one
if it doesn't exist.

Maybe this was some kind of optimization, where you only needed to call the
more expensive version at launch or something?