[webkit-reviews] review granted: [Bug 172481] [WebIDL] Overloaded functions unnecessarily duplicate argument checks : [Attachment 311093] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 172481: [WebIDL] Overloaded functions unnecessarily duplicate argument
checks
https://bugs.webkit.org/show_bug.cgi?id=172481

Attachment 311093: Patch

https://bugs.webkit.org/attachment.cgi?id=311093&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 311093
  --> https://bugs.webkit.org/attachment.cgi?id=311093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311093&action=review

r=me with nit.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4056
> +	   foreach my $function (@functions) {

FYI, I'd personally if we used IDL naming consistently in the bindings
generator. i.e. function -> operation.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4746
> +    return if $function->{overloads} && @{$function->{overloads}} > 1;

Maybe a comment to explain why we do not need argument count check for
overloads?