[webkit-reviews] review granted: [Bug 172299] Web Automation: characters produced with shift modifier on QWERTY keyboard should be delivered as shift-down, char-down, char-up, shift-up events : [Attachment 310727] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 172299: Web Automation: characters produced with shift modifier on QWERTY
keyboard should be delivered as shift-down, char-down, char-up, shift-up events
https://bugs.webkit.org/show_bug.cgi?id=172299

Attachment 310727: Patch

https://bugs.webkit.org/attachment.cgi?id=310727&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 310727
  --> https://bugs.webkit.org/attachment.cgi?id=310727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310727&action=review

r=me

> Source/WebKit2/UIProcess/Automation/mac/WebAutomationSessionMac.mm:521
> +    case 'A':
> +    case 'B':
> +    case 'C':
> +    case 'E':
> +    case 'F':
> +    case 'G':
> +    case 'H':
> +    case 'I':
> +    case 'J':
> +    case 'K':
> +    case 'L':
> +    case 'M':
> +    case 'N':
> +    case 'O':
> +    case 'P':
> +    case 'Q':
> +    case 'R':
> +    case 'S':
> +    case 'T':
> +    case 'U':
> +    case 'V':
> +    case 'W':
> +    case 'X':
> +    case 'Y':
> +    case 'Z':

Can we turn this into an easier to read if statement:

    if (c >= 'A' && c <= 'Z')
	return YES;

The rest can still be in this switch. I realize by putting them all in the
switch the compiler might manage some smarter codegen, but I think readability
is more important here.