[webkit-reviews] review granted: [Bug 171385] Web Inspector: webkit reload policy should match default behavior : [Attachment 310208] Proposed Fix v2

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 171385: Web Inspector: webkit reload policy should match default behavior
https://bugs.webkit.org/show_bug.cgi?id=171385

Attachment 310208: Proposed Fix v2

https://bugs.webkit.org/attachment.cgi?id=310208&action=review




--- Comment #26 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 310208
  --> https://bugs.webkit.org/attachment.cgi?id=310208
Proposed Fix v2

View in context: https://bugs.webkit.org/attachment.cgi?id=310208&action=review

Patch looks good to me, just get the tests passing properly.

> Source/JavaScriptCore/inspector/protocol/Page.json:116
> +		   { "name": "revalidateUnexpiredResources", "type": "boolean",
"optional": true, "description": "If true, unexpired cached subresources will
be revalidated when the main resource loads. Otherwise, only expired cached
subresources will be revalidated (the default behavior for most WebKit
clients)." },

Maybe we should name this revalidateAllResources or just revalidateResources?

>
LayoutTests/http/tests/inspector/network/resource-response-source-memory-cache-
revalidate-expired-only-expected.txt:9
> +FAIL: statusCode should be 200
> +    Expected: 200
> +    Actual: 304

This seems unexpected.