[webkit-reviews] review granted: [Bug 172428] [CoordinatedGraphics] BitmapTexturePool does not release textures properly : [Attachment 310809] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Gwang Yoon Hwang
<yoon at igalia.com>'s request for review:
Bug 172428: [CoordinatedGraphics] BitmapTexturePool does not release textures
properly
https://bugs.webkit.org/show_bug.cgi?id=172428

Attachment 310809: Patch

https://bugs.webkit.org/attachment.cgi?id=310809&action=review




--- Comment #4 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 310809
  --> https://bugs.webkit.org/attachment.cgi?id=310809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310809&action=review

> Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:60
> +	   bool canBeReleased (double minUsedTime) const { return
m_lastUsedTime < minUsedTime && m_texture->refCount() == 1; }

Not related to this patch, but do we properly manage BitmapTexture objects that
are being constructed in different threads (GStreamer threads, main thread for
WebGL/acc. canvas) and then used for rendering on the composition thread?
Should BitmapTexture inherit from ThreadSafeRefCounted?