[webkit-reviews] review granted: [Bug 172119] [CoordinatedGraphics] Clear UpdateAtlases for each tests : [Attachment 310840] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Gwang Yoon Hwang
<yoon at igalia.com>'s request for review:
Bug 172119: [CoordinatedGraphics] Clear UpdateAtlases for each tests
https://bugs.webkit.org/show_bug.cgi?id=172119

Attachment 310840: Patch

https://bugs.webkit.org/attachment.cgi?id=310840&action=review




--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 310840
  --> https://bugs.webkit.org/attachment.cgi?id=310840
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310840&action=review

Thanks!

> Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.cpp:198
> +#if USE(COORDINATED_GRAPHICS)
> +void DrawingAreaWPE::resetUpdateAtlasForTesting()
> +{
> +    ASSERT(m_layerTreeHost);
> +    m_layerTreeHost->clearUpdateAtlases();
> +}
> +#endif

hmm, I wonder why WPE needs its own DrawingArea, I think it should be possible
to use AcceleratedDrawinArea just ensuring that WPE always have AC mode forced,
which I guess it's already ensured. Not related to this bug, though, just that
I noticed it now.