[webkit-reviews] review granted: [Bug 172200] iOS WebRTC Media Capture should not allow camera capture from background tab : [Attachment 310348] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 172200: iOS WebRTC Media Capture should not allow camera capture from
background tab
https://bugs.webkit.org/show_bug.cgi?id=172200

Attachment 310348: Patch

https://bugs.webkit.org/attachment.cgi?id=310348&action=review




--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 310348
  --> https://bugs.webkit.org/attachment.cgi?id=310348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310348&action=review

> Source/WebCore/ChangeLog:11
> +	   On iOS, muting/unmuting the current video source according Document
visibility.

Nit: "muting/unmuting" => "mute/unmute", "according" => "according to"

> Source/WebCore/dom/Document.cpp:6991
> +void Document::notifyVisibilityChangedToMediaCapture()
> +{
> +#if ENABLE(MEDIA_STREAM)
> +    RealtimeMediaSourceCenter::singleton().setVisibility(!hidden());
> +#endif
> +}

Nit: why is it necessary to put this one line call into a separate method?