[webkit-reviews] review granted: [Bug 172196] Import Notification tests from web-platform-tests : [Attachment 310347] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted  review:
Bug 172196: Import Notification tests from web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=172196

Attachment 310347: Patch

https://bugs.webkit.org/attachment.cgi?id=310347&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 310347
  --> https://bugs.webkit.org/attachment.cgi?id=310347
Patch

r=me as long as the bots are happy.

View in context: https://bugs.webkit.org/attachment.cgi?id=310347&action=review

> LayoutTests/resources/testharnessreport.js:18
> +    testRunner.grantWebNotificationPermission(document.origin);

I guess that ideally we should do that conditionally on the widow.location, so
that it only applies to WPT and not other layout tests.
But maybe this is good enough like this. We might want to do the same for
getUserMedia permission then.

It seems a bit different from the other testRunner calls, so maybe there should
be some comments or a line separation here.