[webkit-reviews] review granted: [Bug 172111] [Readable Streams API] Implement ReadableStreamBYOBReader releaseLock() : [Attachment 310127] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Romain Bellessort
<romain.wkt at gmail.com>'s request for review:
Bug 172111: [Readable Streams API] Implement ReadableStreamBYOBReader
releaseLock()
https://bugs.webkit.org/show_bug.cgi?id=172111

Attachment 310127: Patch

https://bugs.webkit.org/attachment.cgi?id=310127&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 310127
  --> https://bugs.webkit.org/attachment.cgi?id=310127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310127&action=review

r=me with a couple of minor comments.

> Source/WebCore/ChangeLog:8
> +	   Added tests to check releaseLock behaviour.

I believe we use US english, so "behavior".

> Source/WebCore/ChangeLog:9
> +

Please always provide a link to the part of the spec you are implementing in
your patch to facilitate review. Here, I would expect it is:
https://streams.spec.whatwg.org/#byob-reader-release-lock
and
https://streams.spec.whatwg.org/#readable-stream-reader-generic-release

> Source/WebCore/Modules/streams/ReadableStreamInternals.js:508
>      reader. at ownerReadableStream = null;

Spec says to set this to undefined, no?