[webkit-reviews] review granted: [Bug 171999] Simplify RealtimeMediaSource data production and state : [Attachment 309933] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 15 09:54:41 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 171999: Simplify RealtimeMediaSource data production and state
https://bugs.webkit.org/show_bug.cgi?id=171999

Attachment 309933: Patch

https://bugs.webkit.org/attachment.cgi?id=309933&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 309933
  --> https://bugs.webkit.org/attachment.cgi?id=309933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309933&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:89
>      m_muted = muted;
>  
> -    if (muted) {
> -	   // FIXME: We need to figure out how to guarantee that at least one
black video frame is
> -	   // emitted after being muted.
> -	   stopProducingData();
> -    } else
> -	   startProducingData();
> +    if (muted)
> +	   stop();
> +    else
> +	   start();
> +
> +    notifyMutedObservers();

It is slightly confusing that we modify m_muted and call notifyMutedObservers()
here and in notifyMutedChange. Is there a reason to not call notifyMutedChange
from here and have it do both?


More information about the webkit-reviews mailing list