[webkit-reviews] review granted: [Bug 171343] Speedometer: Add an Angular 2 (4.x) TodoMVC implementation : [Attachment 308286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 8 22:58:50 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Addy Osmani <addyo at chromium.org>'s
request for review:
Bug 171343: Speedometer: Add an Angular 2 (4.x) TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171343

Attachment 308286: Patch

https://bugs.webkit.org/attachment.cgi?id=308286&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 308286
  --> https://bugs.webkit.org/attachment.cgi?id=308286
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308286&action=review

Hm... Angular version doesn't use localStorage anymore these days? I guess it
works better for us.

> PerformanceTests/ChangeLog:7
> +	   Add a TodoMVC Angular 2 (4.x) implem for the benchmark

Please add a blank line between reviewed-by line and this comment.

> PerformanceTests/ChangeLog:13
> +	   (html,):

Please remove these per-style rule and per-function comments since we're not
adding inline comments for them, and we're just importing from elsewhere.


More information about the webkit-reviews mailing list