[webkit-reviews] review granted: [Bug 171411] Speedometer: Add an Inferno TodoMVC implementation : [Attachment 308489] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 8 22:55:06 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Addy Osmani <addyo at chromium.org>'s
request for review:
Bug 171411: Speedometer: Add an Inferno TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171411

Attachment 308489: Patch

https://bugs.webkit.org/attachment.cgi?id=308489&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 308489
  --> https://bugs.webkit.org/attachment.cgi?id=308489
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308489&action=review

I guess Inferno example doesn't try to restore anything to localStorage in the
first place?

> PerformanceTests/ChangeLog:7
> +	   Adds a Inferno implem of TodoMVC to Speedometer

Please add a blank line between "Reviewed by" and this line.

> PerformanceTests/ChangeLog:10


Please these per-function comments. Since you're not adding any comments,
they're only cluttering the change log.


More information about the webkit-reviews mailing list