[webkit-reviews] review granted: [Bug 171700] [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure : [Attachment 309143] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 4 22:07:53 PDT 2017
Brady Eidson <beidson at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 171700: [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always
marks cookies as secure
https://bugs.webkit.org/show_bug.cgi?id=171700
Attachment 309143: Patch
https://bugs.webkit.org/attachment.cgi?id=309143&action=review
--- Comment #4 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 309143
--> https://bugs.webkit.org/attachment.cgi?id=309143
Patch
Yay!
Looks like you missed the 3rd round of comparisons in the cookie API test,
though.
R+ with fixing that.
More information about the webkit-reviews
mailing list