[webkit-reviews] review granted: [Bug 171713] Web Automation: cookie-related commands don't work correctly : [Attachment 309142] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 171713: Web Automation: cookie-related commands don't work correctly
https://bugs.webkit.org/show_bug.cgi?id=171713

Attachment 309142: Patch

https://bugs.webkit.org/attachment.cgi?id=309142&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 309142
  --> https://bugs.webkit.org/attachment.cgi?id=309142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309142&action=review

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:826
> +	   if (error != CallbackBase::Error::None)
> +	      
callback->sendFailure(STRING_FOR_PREDEFINED_ERROR_NAME(InternalError));
> +	   else
> +	       callback->sendSuccess();

It seems slightly better to start with success case - avoiding negation makes
code a bit easier to understand.