[webkit-reviews] review granted: [Bug 171575] Add a debugging macro that sleeps a thread until a debugger attaches : [Attachment 308932] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 171575: Add a debugging macro that sleeps a thread until a debugger
attaches
https://bugs.webkit.org/show_bug.cgi?id=171575

Attachment 308932: Patch

https://bugs.webkit.org/attachment.cgi?id=308932&action=review




--- Comment #10 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 308932
  --> https://bugs.webkit.org/attachment.cgi?id=308932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308932&action=review

r=me with suggested improvement.

> Source/WTF/wtf/Assertions.h:202
> +#define WTFBreakpointTrap()

Hmmm.  If we want to make WTFBreakpointTrap() an API for more general use, I
question whether it's wise to allow it to fail silently like this if it's not
defined.  Instead, how about defining it as:

#define WTFBreakpointTrap() WTFCrash() // Not implemented

If someone tries to use it, they will crash and the trail will lead to the "Not
implemented" comment.