[webkit-reviews] review granted: [Bug 171669] CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::commonVMSlow + 57 : [Attachment 309058] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 171669: CrashTracer: [USER] com.apple.WebKit.WebContent.Development at
com.apple.WebCore: WebCore::commonVMSlow + 57
https://bugs.webkit.org/show_bug.cgi?id=171669

Attachment 309058: Patch

https://bugs.webkit.org/attachment.cgi?id=309058&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 309058
  --> https://bugs.webkit.org/attachment.cgi?id=309058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309058&action=review

r=me with suggestion for improvement.

> Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp:59
> +    if (!WebCore::g_commonVMOrNull)

While the global can be accessed directly (I suspect just for linkage
purposes), I prefer it if you can introduce a WebCore::commonVMOrNull() inline
function in CommonVM.h, and use that instead.  I prefer that we don't encourage
use of direct access to a global var.