[webkit-reviews] review canceled: [Bug 166695] [ESNext] Async iteration - Implement Async Generator : [Attachment 305431] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 26 14:45:12 PDT 2017

GSkachkov <gskachkov at gmail.com> has canceled GSkachkov <gskachkov at gmail.com>'s
request for review:
Bug 166695: [ESNext] Async iteration - Implement Async Generator

Attachment 305431: Patch


--- Comment #45 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 305431
  --> https://bugs.webkit.org/attachment.cgi?id=305431

View in context: https://bugs.webkit.org/attachment.cgi?id=305431&action=review

>> Source/JavaScriptCore/builtins/AsyncGeneratorPrototype.js:77
>> +	@asyncGeneratorResumeNext(generator);
> I think it might be wise to make AsyncGeneratorResumeNext() behave as a loop,
so that this recursion can be avoided when there are multiple yields and
multiple requests in the queue, unless the spec is changed to get rid of the
"evaluate the next item in queue after a yield immediately".
> I'm sure I've said this in this bug before, but I see that we're still doing
this recursively, and without PTC (though I'm not sure if PTC would help much
in this case).

Thanks for quick feedback!

Yeah, I remember your comment
https://bugs.webkit.org/show_bug.cgi?id=166695#c39, however I've tried to be
close to spec as much as I can, so I implemented (p
But you are right, using loop is better in this place, so I'll try to switch to
approach with loop.

More information about the webkit-reviews mailing list