[webkit-reviews] review granted: [Bug 170108] Air should use RegisterSet for RegLiveness : [Attachment 305434] the patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 170108: Air should use RegisterSet for RegLiveness
https://bugs.webkit.org/show_bug.cgi?id=170108

Attachment 305434: the patch

https://bugs.webkit.org/attachment.cgi?id=305434&action=review




--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 305434
  --> https://bugs.webkit.org/attachment.cgi?id=305434
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305434&action=review

r=me

> Source/JavaScriptCore/b3/B3TimingScope.cpp:60
> +    return ensurePointer(s_state, [] { return new State(); });

Nice thing!

> Source/JavaScriptCore/b3/air/AirLiveness.h:-403
> -typedef AbstractLiveness<RegLivenessAdapter> RegLiveness;

OK, this will be replaced with specialized RegLiveness, which uses RegisterSet.

> Source/JavaScriptCore/b3/air/AirRegLiveness.cpp:95
> +}

OK, it is (logically) identical to the AbstractLiveness one.