[webkit-reviews] review granted: [Bug 173874] DocumentLoader should always notify the client if there are pending icon loads when the load is stopped : [Attachment 314051] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 28 12:34:12 PDT 2017
Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 173874: DocumentLoader should always notify the client if there are pending
icon loads when the load is stopped
https://bugs.webkit.org/show_bug.cgi?id=173874
Attachment 314051: Patch
https://bugs.webkit.org/attachment.cgi?id=314051&action=review
--- Comment #11 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 314051
--> https://bugs.webkit.org/attachment.cgi?id=314051
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=314051&action=review
r=me
> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:224
> + RetainPtr<WKWebViewConfiguration> configuration =
adoptNS([[WKWebViewConfiguration alloc] init]);
Apparently auto is the cool new thing to do in places like this.
More information about the webkit-reviews
mailing list