[webkit-reviews] review granted: [Bug 173934] Web Inspector: Cleanup Protocol JSON files : [Attachment 314048] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 173934: Web Inspector: Cleanup Protocol JSON files
https://bugs.webkit.org/show_bug.cgi?id=173934

Attachment 314048: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=314048&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 314048
  --> https://bugs.webkit.org/attachment.cgi?id=314048
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=314048&action=review

r=me, let's fix up some of these typos while we're at it!

> Source/JavaScriptCore/inspector/protocol/DOM.json:434
>		   { "name": "nodeId", "$ref": "NodeId", "description": "Id of
the node to retrieve attibutes for." }

attibutes -> attributes

> Source/JavaScriptCore/inspector/protocol/DOM.json:499
>		   { "name": "name", "type": "string", "description": "A
ttribute name." }

A ttribute -> Attribute

> Source/JavaScriptCore/inspector/protocol/DOM.json:530
>		   { "name": "previousNodeId", "$ref": "NodeId", "description":
"If of the previous siblint." },

siblint -> sibling

> Source/JavaScriptCore/inspector/protocol/DOMDebugger.json:63
>		   { "name": "isRegex", "type": "boolean", "optional": true,
"descriprion": "Whether the URL string is a regular expression." }

descriprion -> description

> Source/JavaScriptCore/inspector/protocol/Debugger.json:42
>		   { "name": "data", "type": "string", "optional": true,
"description": "Data associated with this breakpoint type (e.g. for type
\"eval\" this is the JavaScript string to evalulate)." },

evalulate -> evaluate

> Source/JavaScriptCore/inspector/protocol/Page.json:140
>		   { "name": "url", "type": "string", "description": "URL to
match cooke domain and path." }

cooke -> cookie

> Source/JavaScriptCore/inspector/protocol/Runtime.json:328
> +	       "description": "Returns detailed informtation on given
function.",

informtation -> information

> Source/JavaScriptCore/inspector/protocol/Runtime.json:368
>		   { "name": "context", "$ref": "ExecutionContextDescription",
"description": "A newly created execution contex." }

contex -> context