[webkit-reviews] review granted: [Bug 173437] Web Inspector: Add small delay before showing the progress spinner when loading resources : [Attachment 313014] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173437: Web Inspector: Add small delay before showing the progress spinner
when loading resources
https://bugs.webkit.org/show_bug.cgi?id=173437

Attachment 313014: Patch

https://bugs.webkit.org/attachment.cgi?id=313014&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 313014
  --> https://bugs.webkit.org/attachment.cgi?id=313014
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313014&action=review

> Source/WebInspectorUI/ChangeLog:13
> +	   Delay the creation of the spinner for 100ms.  If the content is
available before then, just
> +	   clear the timeout and the spinner will never be created/shown.

I know I suggested 100ms, but lets try to arrive at this with more data.

What is the average amount of time it takes for the frontend to load an image
when inspecting (1) locally and (2) remotely.

Testing with your Mac Retina laptop should good. I can get you an iOS device to
test with.

Once we have that average / bucketed histogram we can provide justification for
this currently magic value.