[webkit-reviews] review granted: [Bug 173429] Add a JSRunLoopTimer registry in VM. : [Attachment 313017] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 15 15:36:06 PDT 2017


Filip Pizlo <fpizlo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 173429: Add a JSRunLoopTimer registry in VM.
https://bugs.webkit.org/show_bug.cgi?id=173429

Attachment 313017: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=313017&action=review




--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 313017
  --> https://bugs.webkit.org/attachment.cgi?id=313017
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=313017&action=review

r=me

> Source/JavaScriptCore/runtime/VM.h:681
> +    void registerRunLoop(JSRunLoopTimer*);
> +    void unregisterRunLoop(JSRunLoopTimer*);

Can we rename these to registerRunLoopTimer and unregisterRunLoopTimer?


More information about the webkit-reviews mailing list