[webkit-reviews] review granted: [Bug 173311] Do not mix C and C++ API error constants : [Attachment 312766] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173311: Do not mix C and C++ API error constants
https://bugs.webkit.org/show_bug.cgi?id=173311

Attachment 312766: Patch

https://bugs.webkit.org/attachment.cgi?id=312766&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312766
  --> https://bugs.webkit.org/attachment.cgi?id=312766
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312766&action=review

> Source/WebKit2/Shared/API/APIError.h:51
> +    enum General {

We're trying to use more enum classes in WebKit unless there's a good reason
not to.  And we need to be sure to have source and binary compatibility, which
I think this patch has.