[webkit-reviews] review denied: [Bug 173308] [Win64] Fails to build Asm.lib (PaintHooks.asm) since Bug 173132 : [Attachment 312764] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 13 09:53:16 PDT 2017
Alex Christensen <achristensen at apple.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 173308: [Win64] Fails to build Asm.lib (PaintHooks.asm) since Bug 173132
https://bugs.webkit.org/show_bug.cgi?id=173308
Attachment 312764: Patch
https://bugs.webkit.org/attachment.cgi?id=312764&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312764
--> https://bugs.webkit.org/attachment.cgi?id=312764
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312764&action=review
> Source/WebKit/PlatformWin.cmake:261
> + OUTPUT
${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/PaintHooks.obj
https://trac.webkit.org/changeset/216332/webkit uses a derived sources
directory. This should do the same.
More information about the webkit-reviews
mailing list