[webkit-reviews] review denied: [Bug 173145] Add API::IconDatabaseClient : [Attachment 312418] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 9 10:24:40 PDT 2017
Alex Christensen <achristensen at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173145: Add API::IconDatabaseClient
https://bugs.webkit.org/show_bug.cgi?id=173145
Attachment 312418: Patch
https://bugs.webkit.org/attachment.cgi?id=312418&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312418
--> https://bugs.webkit.org/attachment.cgi?id=312418
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312418&action=review
> Source/WebKit2/UIProcess/WebIconDatabase.h:118
> + std::unique_ptr<API::IconDatabaseClient> m_client;
I think this is wrong. Usually we have the API object own the WebKit namespace
object.
More information about the webkit-reviews
mailing list