[webkit-reviews] review denied: [Bug 173150] Add API::GeolocationProvider : [Attachment 312423] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 9 10:23:37 PDT 2017
Alex Christensen <achristensen at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173150: Add API::GeolocationProvider
https://bugs.webkit.org/show_bug.cgi?id=173150
Attachment 312423: Patch
https://bugs.webkit.org/attachment.cgi?id=312423&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312423
--> https://bugs.webkit.org/attachment.cgi?id=312423
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312423&action=review
> Source/WebKit2/UIProcess/WebGeolocationManagerProxy.h:84
> + std::unique_ptr<API::GeolocationProvider> m_provider;
I think this is wrong. Usually we have the API object own the WebKit namespace
object.
More information about the webkit-reviews
mailing list