[webkit-reviews] review granted: [Bug 172929] webkitpy: Extract ScriptError to its own file : [Attachment 312021] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 172929: webkitpy: Extract ScriptError to its own file
https://bugs.webkit.org/show_bug.cgi?id=172929

Attachment 312021: Patch

https://bugs.webkit.org/attachment.cgi?id=312021&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 312021
  --> https://bugs.webkit.org/attachment.cgi?id=312021
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312021&action=review

Please fix the copyright.

> Tools/Scripts/webkitpy/common/system/scripterror.py:1
> +# Copyright (C) 2017 Apple Inc. All rights reserved.

Clearly, the content of this file is copyrighted by Google in 2009, 2010, 2011
and 2013.
e.g.
https://trac.webkit.org/browser/webkit/trunk/WebKitTools/Scripts/modules/execut
ive.py?rev=51891
https://trac.webkit.org/changeset/53777/webkit/trunk/WebKitTools/Scripts/webkit
py/executive.py
https://trac.webkit.org/changeset/75586/webkit/trunk/Tools/Scripts/webkitpy/com
mon/system/executive.py
https://trac.webkit.org/changeset/143910/webkit/trunk/Tools/Scripts/webkitpy/co
mmon/system/executive.py
https://trac.webkit.org/changeset/202362/webkit/trunk/Tools/Scripts/webkitpy/co
mmon/system/executive.py

I recommend looking through the blame. Also, since we're not adding any content
in 2017,
it's probably misnomer to claim copyright this year even though we're moving
the content.