[webkit-reviews] review granted: [Bug 171535] [GCrypt] ECDSA signing results can be smaller than the EC key size : [Attachment 312297] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 171535: [GCrypt] ECDSA signing results can be smaller than the EC key size
https://bugs.webkit.org/show_bug.cgi?id=171535

Attachment 312297: Patch

https://bugs.webkit.org/attachment.cgi?id=312297&action=review




--- Comment #5 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 312297
  --> https://bugs.webkit.org/attachment.cgi?id=312297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312297&action=review

r=me

Looks good. Please address the following comments.

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:117
> +	   || extractECDSASignatureInteger(signature, signatureSexp, "s",
keySizeInBytes))

Should be !extractECDSASignatureInteger(signature, signatureSexp, "s",
keySizeInBytes)?