[webkit-reviews] review granted: [Bug 173038] Refactoring: MediaEngineSupportParameters should take a ContentType rather than separate type & codecs strings : [Attachment 312204] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 173038: Refactoring: MediaEngineSupportParameters should take a ContentType
rather than separate type & codecs strings
https://bugs.webkit.org/show_bug.cgi?id=173038

Attachment 312204: Patch

https://bugs.webkit.org/attachment.cgi?id=312204&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 312204
  --> https://bugs.webkit.org/attachment.cgi?id=312204
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312204&action=review

> Source/WebCore/platform/ContentType.cpp:82
>      String strippedType = m_type.stripWhiteSpace();

A little bird told me that we should use probably always
stripWhite(isHTMLSpace).

> Source/WebCore/platform/ContentType.cpp:92
> +static String simplifyWhitespace(const String& string)

...and that this was probably not necessary.