[webkit-reviews] review denied: [Bug 173069] Web Inspector: Decrease vertical spacing of pseudo-class toggles : [Attachment 312209] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 7 13:26:12 PDT 2017


Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 173069: Web Inspector: Decrease vertical spacing of pseudo-class toggles
https://bugs.webkit.org/show_bug.cgi?id=173069

Attachment 312209: Patch

https://bugs.webkit.org/attachment.cgi?id=312209&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 312209
  --> https://bugs.webkit.org/attachment.cgi?id=312209
Patch

r- for now, I think Nikita has a good point.

Also, the height of the pseudo class area (31px) is related to the height of
the navigation bar above it (29px, the difference is probably borders). Is the
new height arbitrary or does it correspond to something?

That said I think it would be a good idea to revisit the Styles sidebar in the
future, but we should do that as part of a larger effort to streamline the UI.


More information about the webkit-reviews mailing list