[webkit-reviews] review granted: [Bug 173057] [JSC] has_generic_property never accepts non-String : [Attachment 312182] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 173057: [JSC] has_generic_property never accepts non-String
https://bugs.webkit.org/show_bug.cgi?id=173057

Attachment 312182: Patch

https://bugs.webkit.org/attachment.cgi?id=312182&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 312182
  --> https://bugs.webkit.org/attachment.cgi?id=312182
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312182&action=review

> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:717
> +    ASSERT(property.isString());
> +    RETURN(jsBoolean(base->hasPropertyGeneric(exec,
asString(property.asCell())->toIdentifier(exec),
PropertySlot::InternalMethodType::GetOwnProperty)));

The asString function already does this assertion; separately asserting is
unnecessary.